Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-12319

QGLBuffer::release and QGLBuffer::bind should not be const

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P1: Critical
    • 4.7.0
    • 4.7.0
    • GUI: OpenGL
    • None
    • 3a08c5b1682e211bf664c21850187e2b15e89c23

    Description

      release is an operation that modifies the buffer, the fact that you can make it const because the way you have implemented the class does not mean it makes sense from the logical point of view.
      Same for bind.

      Any C++ coder will agree that a function that return void and is const logically implies it is a noop, since returns nothing and does not modify your object

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            kjernase Trond Kjernåsen (Inactive)
            acidpk Albert Astals Cid (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes