Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-123295

DomBase: clean up doCopy() and copy constructors and mutexes

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • P2: Important
    • Some future release
    • 6.7
    • QML: Tooling
    • None
    • c9e1d1d50 (dev)

    Description

      The DomBase hierarchy is super weird with respect to copy constructors: it ignores the rule of 0/3/5 and one of the base classes (OwningItem) has a mutex and a copy constructor at the same time.

      Also, it has methods doCopy() that should be called clone() and that just call the copy constructor it seems?

      Attachments

        Issue Links

          resulted from

          Task - A task that needs to be done. QTBUG-122645 dom: support semantic analysis for dependencies

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          For Gerrit Dashboard: QTBUG-123295
          # Subject Branch Project Status CR V
          546789,10 dom: use implicit QmlComponent copy constructor dev qt/qtdeclarative Status: MERGED +2 0
          547732,4 WIP: dom: enforce rule of 3 for DomBase hierarchy dev qt/qtdeclarative Status: DEFERRED -2 0

          Activity

            People

              qtqmlteam Qt Qml Team User
              sami.shalayel Sami Shalayel
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There are no open Gerrit changes