Details
-
Bug
-
Resolution: Unresolved
-
P2: Important
-
None
-
5.15.13
-
None
-
5fcbb5792 (87-based)
Description
I observed this issue with the Vcpkg port of qt5-webengine 5.15.13-0. It has patches but nothing in the vicinity of this error. It looks legit too. Basically both src/3rdparty/chromium/third_party/blink/renderer/core/layout/svg/svg_layout_tree_as_text.cc and src/3rdparty/chromium/third_party/blink/renderer/core/layout/svg/layout_svg_resource_paint_server.cc define a static function ResolveColor( )with the exact same signature causing this redefinition error when running a jumbo build (the default). This is the build failure:
FAILED: obj/third_party/blink/renderer/core/layout/svg/svg_layout/svg_layout_jumbo_4.o /usr/bin/c++ -MMD -MF obj/third_party/blink/renderer/core/layout/svg/svg_layout/svg_layout_jumbo_4.o.d -DUSE_UDEV -DUSE_AURA=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DTOOLKIT_QT -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DBLINK_CORE_IMPLEMENTATION=1 -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -DUSING_SYSTEM_ICU=1 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DUCHAR_TYPE=uint16_t -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -DABSL_ALLOCATOR_NOTHROW=1 -DWEBRTC_USE_BUILTIN_ISAC_FIX=0 -DWEBRTC_USE_BUILTIN_ISAC_FLOAT=1 -DWEBRTC_USE_X11 -DWEBRTC_USE_X11 -DHAVE_SCTP -DNO_MAIN_THREAD_WRAPPING -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DSK_CODEC_DECODES_PNG -DSK_CODEC_DECODES_WEBP -DSK_ENCODE_PNG -DSK_ENCODE_WEBP -DSK_USER_CONFIG_HEADER=\"../../skia/config/SkUserConfig.h\" -DSK_GL -DSK_CODEC_DECODES_JPEG -DSK_ENCODE_JPEG -DSK_USE_LIBGIFCODEC -DSK_VULKAN_HEADER=\"../../skia/config/SkVulkanConfig.h\" -DSK_VULKAN=1 -DSK_SUPPORT_GPU=1 -DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\" -DV8_ENABLE_CHECKS -DV8_COMPRESS_POINTERS -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_DEPRECATION_WARNINGS -DV8_REVERSE_JSARGS -DUSING_SYSTEM_ICU=1 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DUCHAR_TYPE=uint16_t -DCRASHPAD_ZLIB_SOURCE_EXTERNAL -DLEVELDB_PLATFORM_CHROMIUM=1 -DLEVELDB_PLATFORM_CHROMIUM=1 -DSUPPORT_WEBGL2_COMPUTE_CONTEXT=1 -DWTF_USE_WEBAUDIO_PFFFT=1 -DUSE_BLINK_V8_BINDING_NEW_IDL_INTERFACE -DUSE_SYSTEM_LIBJPEG -DV8_ENABLE_CHECKS -DV8_COMPRESS_POINTERS -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_DEPRECATION_WARNINGS -DV8_REVERSE_JSARGS -DLIBXSLT_STATIC -I. -Igen -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -Igen -Igen -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/libyuv/include -Igen -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/jsoncpp/source/include -Igen -Igen -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/vulkan_headers/include -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/khronos -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/gpu -Igen/third_party/dawn/src/include -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/dawn/src/include -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/abseil-cpp -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/boringssl/src/include -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/protobuf/src -Igen/protoc_out -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/ced/src -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/webrtc_overrides -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/webrtc -Igen/third_party/webrtc -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/protobuf/src -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/skia -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/libgifcodec -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/vulkan/include -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/vulkan_headers/include -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/angle/include -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/angle/src/common/third_party/base -Igen/angle -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/angle/include -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/v8/include -Igen/v8/include -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/crashpad/crashpad -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/crashpad/crashpad/compat/non_mac -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/crashpad/crashpad/compat/linux -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/crashpad/crashpad/compat/non_win -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/zlib -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/mesa_headers -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/libwebm/source -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/leveldatabase -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/leveldatabase/src -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/leveldatabase/src/include -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/iccjpeg -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/ots/include -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/v8/include -Igen/v8/include -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/libxml/src/include -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/libxml/linux/include -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/libxslt/src -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/snappy/src -I../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/snappy/linux -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -pthread -m64 -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -Wall -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-deprecated-declarations -fno-delete-null-pointer-checks -Wno-comments -Wno-packed-not-aligned -Wno-dangling-else -Wno-missing-field-initializers -Wno-unused-parameter -fno-omit-frame-pointer -fvisibility=hidden -Os -g0 -Wno-unused-variable -I/home/ts/src/easyviz/build/vcpkg_installed/x64-linux-dynamic/lib/pkgconfig/../../include -I/home/ts/src/easyviz/build/vcpkg_installed/x64-linux-dynamic/lib/pkgconfig/../../include -I/usr/include/nss3 -I/usr/include/nspr4 -I/home/ts/src/easyviz/build/vcpkg_installed/x64-linux-dynamic/lib/pkgconfig/../../include -I/home/ts/src/easyviz/build/vcpkg_installed/x64-linux-dynamic/lib/pkgconfig/../../include/libpng16 -I/home/ts/src/easyviz/build/vcpkg_installed/x64-linux-dynamic/lib/pkgconfig/../../include -I/home/ts/src/easyviz/build/vcpkg_installed/x64-linux-dynamic/lib/pkgconfig/../../include -I/home/ts/src/easyviz/build/vcpkg_installed/x64-linux-dynamic/lib/pkgconfig/../../include/webp -DLIBXML_STATIC= -std=gnu++14 -Wno-narrowing -Wno-class-memaccess -Wno-attributes -Wno-class-memaccess -Wno-subobject-linkage -Wno-invalid-offsetof -Wno-return-type -Wno-deprecated-copy -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -Wno-deprecated-declarations -c gen/third_party/blink/renderer/core/layout/svg/svg_layout_jumbo_4.cc -o obj/third_party/blink/renderer/core/layout/svg/svg_layout/svg_layout_jumbo_4.o In file included from gen/third_party/blink/renderer/core/layout/svg/svg_layout_jumbo_4.cc:16: ./../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/blink/renderer/core/layout/svg/svg_layout_tree_as_text.cc:255:30: error: redefinition of 'base::Optional<blink::Color> blink::ResolveColor(const blink::ComputedStyle&, const blink::SVGPaint&, const blink::SVGPaint&)' 255 | static base::Optional<Color> ResolveColor(const ComputedStyle& style, | ^~~~~~~~~~~~ In file included from gen/third_party/blink/renderer/core/layout/svg/svg_layout_jumbo_4.cc:5: ./../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/blink/renderer/core/layout/svg/layout_svg_resource_paint_server.cc:97:30: note: 'base::Optional<blink::Color> blink::ResolveColor(const blink::ComputedStyle&, const blink::SVGPaint&, const blink::SVGPaint&)' previously defined here 97 | static base::Optional<Color> ResolveColor(const ComputedStyle& style, | ^~~~~~~~~~~~ In file included from gen/third_party/blink/renderer/core/layout/svg/svg_layout_jumbo_4.cc:16: ./../../../../src/5.15.13-38459bd7fb.clean/src/3rdparty/chromium/third_party/blink/renderer/core/layout/svg/svg_layout_tree_as_text.cc:255:30: warning: 'base::Optional<blink::Color> blink::ResolveColor(const blink::ComputedStyle&, const blink::SVGPaint&, const blink::SVGPaint&)' defined but not used [-Wunused-function] 255 | static base::Optional<Color> ResolveColor(const ComputedStyle& style, | ^~~~~~~~~~~~
I've observed this when building on AlmaLinux 9.3 with the stock gcc 11.4.1.
vcpkg issue: vcpkg #37448.
Attachments
Gerrit Reviews
For Gerrit Dashboard: QTBUG-123328 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
551784,2 | Prevent duplicate definition of blink::ResolveColor in jumbo builds | 87-based | qt/qtwebengine-chromium | Status: MERGED | +2 | 0 |