Loading...

XML

Word

Printable

Details

Type: Bug
Resolution: Fixed
Priority: P3: Somewhat important
Fix Version/s: 6.7.1, 6.8.0 FF
Affects Version/s: 6.7, 6.8
Component/s: Core: Containers and Algorithms
Labels:
None

Commits:
8381a4b44 (dev), d204ea987 (dev), 848451095 (dev), 4e7f906b0 (6.7), 29213f254 (6.7), f88091c19 (6.7)

Description

Somehow this is producing duplicated names for the char16_t and char32_t rows generated by addSingleType(), a helper lambda inside compareNumerics_data():

    PASS   : tst_QVariant::convertToQUint8()
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char16_t(0)-char16_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char16_t(0)-char16_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char16_t(0)-char16_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char16_t(0)-char16_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char16_t(0)-char16_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char16_t(0)-char16_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char16_t(0)-char16_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char16_t(0)-char16_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char16_t(0)-char16_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char16_t(0)-char16_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char16_t(0)-char16_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char16_t(0)-char16_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char16_t(0)-char16_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char16_t(0)-char16_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char16_t(0)-char16_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char32_t(0)-char32_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char32_t(0)-char32_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char32_t(0)-char32_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char32_t(0)-char32_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char32_t(0)-char32_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char32_t(0)-char32_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char32_t(0)-char32_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char32_t(0)-char32_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char32_t(0)-char32_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char32_t(0)-char32_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char32_t(0)-char32_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char32_t(0)-char32_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char32_t(0)-char32_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char32_t(0)-char32_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "char32_t(0)-char32_t(0)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "qlonglong(-9223372036854775808)-qlonglong(9223372036854775807)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "float(0)-double(1)" - please rename.
    QWARN  : tst_QVariant::compareNumerics() Duplicate data tag "float(1.1754943508222875e-38)-double(2.2250738585072014e-308)" - please rename.

(The qlonglong and float-double cases are likely results of type aliases.)
These tests do all pass, but should ideally have distinct data tag names.
Given that there are 15 duplicates of each (plus the one they all duplicate) I must suppose addSingleType()'s arithmetic isn't behaving as intended: apparently it's producing a list of four zeros. Either that or some of the QVariant machinery via which the values get packaged is misfiring.

Adding

    qDebug() << "char16_t(1) -> QVariant:"
             << QVariant::fromValue(char16_t(1)).toUInt()
             << QString::number(QVariant::fromValue(char16_t(1)).toUInt());

early in compareNumerics_data() I get the report

QDEBUG : tst_QVariant::compareNumerics() char16_t(1) -> QVariant: 0 "0"

so it would seem the QVariant machinery is what's failing.

Attachments

Issue Links

relates to

QTBUG-107185 Some tests appear to be re-testing the exact same data tag

Closed

QTQAINFRA-5187 Some tests having multiple PASS results even over 300 times - Should they have more unique test_names

Closed

Gerrit Reviews

- Issue Only
- Show All Reviews
- Show Open Reviews
- Show All Issues
- Show Open Issues

For Gerrit Dashboard: QTBUG-124349
#	Subject	Branch	Project	Status	CR	V
554746,2	tst_QVariant: fix copy & paste error in double-float comparisons	dev	qt/qtbase	Status: MERGED	+2	0
554747,2	tst_QVariant: remove duplicate rows from compareNumerics	dev	qt/qtbase	Status: MERGED	+2	0
554768,2	tst_QVariant: fix stringification of char16_t and char32_t	dev	qt/qtbase	Status: MERGED	+2	0
555193,2	tst_QVariant: fix copy & paste error in double-float comparisons	6.7	qt/qtbase	Status: MERGED	+2	0
555194,2	tst_QVariant: remove duplicate rows from compareNumerics	6.7	qt/qtbase	Status: MERGED	+2	0
555195,2	tst_QVariant: fix stringification of char16_t and char32_t	6.7	qt/qtbase	Status: MERGED	+2	0