Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-124362

Chromium version in official tarball does not match version in GIT

    XMLWordPrintable

Details

    • Bug
    • Resolution: Moved
    • P3: Somewhat important
    • None
    • 6.7.0
    • WebEngine
    • None
    • All

    Description

      Hi,

       

      If I check the tag 6.7.0 in qtwebengine.git , CHROMIUM_VERSION says I should have:

       

      Based on Chromium version:                                      118.0.5993.220
      Patched with security patches up to Chromium version:           122.0.6261.128

       

      If I check Chromium at 118.0.5993.220 on Github for file ffmpeg_common:

       

      https://github.com/chromium/chromium/blob/118.0.5993.220/media/ffmpeg/ffmpeg_common.cc#L339

      I have this code:

       

        ChannelLayout channel_layout =
            codec_context->ch_layout.nb_channels > 8
                ? CHANNEL_LAYOUT_DISCRETE
                : ChannelLayoutToChromeChannelLayout(
                      codec_context->ch_layout.u.mask,
                      codec_context->ch_layout.nb_channels);

       

      which would allow me to build with FFMPEG 7 with no issue.

       

      I check the official tarball for 6.7.0 I have:

        ChannelLayout channel_layout =
            codec_context->channels > 8
                ? CHANNEL_LAYOUT_DISCRETE
                : ChannelLayoutToChromeChannelLayout(codec_context->channel_layout,
                                                     codec_context->channels);

      The oldest version that should contain the correct code is 102.0.4980.0, why is it that Qt qtwebengine Chromium 118.0.5993.220 does not contain that code?

      It seems that when Chromium 112 was imported, it did:

      https://codereview.qt-project.org/gitweb?p=qt/qtwebengine-chromium.git;a=blob;f=chromium/media/ffmpeg/ffmpeg_common.cc;h=76f03d6608e57f833359f57c2c02024924815424;hb=774f54339e5db91f785733232d3950366db65d07

       

      But then the commit "Fix building with system ffmpeg"

      https://codereview.qt-project.org/gitweb?p=qt/qtwebengine-chromium.git;a=commitdiff;h=ca960e2fae850469dfc54a5a4588d68d440a4326

      rolled back the correct code to build with recent FFMPEG? What was the "system ffmpeg" chosen? Considering the various system out there, how was this determined?

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            qt_webengine_team Qt WebEngine Team
            eclipseo Robert-André Mauchin
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes