Details
-
Bug
-
Resolution: Unresolved
-
P3: Somewhat important
-
None
-
6.7.0
-
None
-
cf19105e0 (dev), a4c271007 (6.7), 9ea2ff075 (tqtc/lts-6.5)
Description
The rule for enums in signal/slot declarations is to use the class-scoped enum name (https://github.com/KDE/clazy/blob/master/docs/checks/README-fully-qualified-moc-types.md). QThread::start() violates this, but changing it now breaks existing users.
Can we maybe overload the two, for moc, fabiankosmale?
Attachments
Issue Links
- links to
-
qt_Essentials_qtcore_dev_linux:SV669 warning: Qt-FullyQualifiedMocTypes: SLOT arguments need to be fully-qualified (QThread::Priority instead of Priority). [start()]
Gerrit Reviews
For Gerrit Dashboard: QTBUG-124723 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
557972,1 | QThread: check various ways users may use start(Priority) | tqtc/lts-6.2 | qt/tqtc-qtbase | Status: NEW | +2 | 0 |
557302,4 | QThread: check various ways users may use start(Priority) | dev | qt/qtbase | Status: MERGED | +2 | +1 |
557646,2 | QThread: check various ways users may use start(Priority) | 6.7 | qt/qtbase | Status: MERGED | +2 | 0 |
557954,4 | QThread: check various ways users may use start(Priority) | tqtc/lts-6.5 | qt/tqtc-qtbase | Status: MERGED | +2 | -1 |