Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-124789

Use inline namespaces when generating code with the EXTRA_NAMESPACE option

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • P2: Important
    • None
    • 6.8
    • Protocol Buffers
    • None

    Description

      The current EXTRA_NAMESPACE option behavior breaks the protobuf package consistency and disallow the use of the generated protobuf libraries without the knowledge of what EXTRA_NAMESPACE was used while generating the code.

      The potential issue that namespace helps to solve - duplicated symbols at linker time, which still can be addressed by using inline namespace. We should generate the inline namespace in both scenario when EXTRA_NAMESPACE option is set and and it is not set. This won't avoid ambiguity when using messages from two different sources at compile time(which we now may treat as user failure), but prevents linker-time issue.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            tatiana.borisova Tatiana Borisova
            semlanik Alexey Edelev
            Vladimir Minenko Vladimir Minenko
            Alex Blasche Alex Blasche
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes