Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-124909

QtPrivate::Continuation should not be polymorphic

XMLWordPrintable

    • 5
    • e53df7a02 (dev), e571a8201 (6.7), 699162c6f (dev)
    • Foundation Sprint 112, Foundation Sprint 113

      The Continuation class template acts as an interface for Sync and Async subclasses. Since it's a class template, each use will likely instantiate a new type, complete with vtable and type_info object.

      The class should be rewritten to use the new goodies we have added, e.g. QGenericRunnable, CompactStorage, and maybe even QCallableObject to avoid virtuals.

        For Gerrit Dashboard: QTBUG-124909
        # Subject Branch Project Status CR V
        558976,2 QtPrivate::Continuation: add missing Q_DISABLE_COPY(_MOVE) dev qt/qtbase Status: MERGED +2 0
        559093,2 QtPrivate::Continuation: add missing Q_DISABLE_COPY(_MOVE) 6.7 qt/qtbase Status: MERGED +2 0
        576869,6 Rework QtPrivate::Continuation to get rid of virtual calls and rename it dev qt/qtbase Status: MERGED +2 +1

            ivan.solovev Ivan Solovev
            mmutz Marc Mutz
            Vladimir Minenko Vladimir Minenko
            Alex Blasche Alex Blasche
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes