Details
-
Bug
-
Resolution: Fixed
-
P2: Important
-
6.7, 6.8.0 FF
-
None
-
151ad6818 (dev), df24d92f8 (6.7), 4a61dc714 (dev), cc362edca (6.8), 36070fffc (6.7)
-
Foundation Sprint 108
Description
When qt_add_protobuf or qt_add_grpc is invoked without an existing target (and a library is created) then the generated export header:
/* This file is autogenerated. DO NOT CHANGE. All changes will be lost */ #if defined(QT_SHARED) || !defined(QT_STATIC) # if defined(QT_BUILD_QTCLIENT-PROTO_LIB) # define QPB_QTCLIENT-PROTO_EXPORT Q_DECL_EXPORT # else # define QPB_QTCLIENT-PROTO_ EXPORT Q_DECL_IMPORT # endif #else # define QPB_QTCLIENT-PROTO_EXPORT #endif
is broken due to 'QT_BUILD_QTCLIENT-PROTO_LIB' as "-" is not supported as macro / preprocessor name.
Attachments
| For Gerrit Dashboard: QTBUG-125328 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 563242,4 | qt{proto,grpc}gen: handle invalid c identifier for export macros | dev | qt/qtgrpc | Status: MERGED | +2 | +1 |
| 563982,2 | qt{proto,grpc}gen: handle invalid c identifier for export macros | 6.7 | qt/qtgrpc | Status: MERGED | +2 | 0 |
| 568855,6 | Avoid overlapping test data by cmdLineInvalidExportMacro test | dev | qt/qtgrpc | Status: MERGED | +2 | 0 |
| 573435,2 | Avoid overlapping test data by cmdLineInvalidExportMacro test | 6.8 | qt/qtgrpc | Status: MERGED | +2 | 0 |
| 573563,2 | Avoid overlapping test data by cmdLineInvalidExportMacro test | 6.7 | qt/qtgrpc | Status: MERGED | +2 | 0 |