Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-125384

graphstheme using qjsvalue for gradients

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: P2: Important P2: Important
    • None
    • None
    • Graphs: 2D, Graphs: 3D
    • None
    • 8284bf6b0 (dev), f259e9ae4 (6.8)

      QJSValue is indeed a rather expensive way to pas data – also, it forces you to handle a type mismatch at runtime. Note that you can use Q_PRIVATE_PROPERTY if you want to avoid having setters taking private API types in public API.

      https://codereview.qt-project.org/c/qt/qtgraphs/+/560943/comment/ae2a51e6_19cecacf/

        1. 1.png
          1.png
          12 kB
        2. 2.png
          2.png
          77 kB
        3. 3.png
          3.png
          24 kB
        4. 4.png
          4.png
          31 kB
        5. 5.png
          5.png
          35 kB
        For Gerrit Dashboard: QTBUG-125384
        # Subject Branch Project Status CR V
        567378,3 Change QJSValue to a specific type dev qt/qtgraphs Status: MERGED +2 0
        568002,2 Change QJSValue to a specific type 6.8 qt/qtgraphs Status: MERGED +2 0

            kwpark Kwanghyo Park
            oulu_hillbilly Sami Varanka
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes