Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-125756

Rename misleading variable QT_ANDROID_API_VERSION in CMake and qmake

    XMLWordPrintable

Details

    • Android
    • 8d2d5563b (dev)
    • 2024wk36s2FOQtforAndroid

    Description

      The variable QT_ANDROID_API_VERSION use in https://github.com/qt/qtbase/blob/4656fabd8a6ff46f786cb48c220511ebe43ea300/cmake/QtPlatformAndroid.cmake#L39 (and the qmake counterpart API_TO_USE https://github.com/qt/qtbase/blob/4656fabd8a6ff46f786cb48c220511ebe43ea300/mkspecs/features/android/sdk.prf#L3) are misleadingly named, those two variables refer to the android api level used to build Qt for Android Java code only, where it's needed to use the latest or the max we target.

      What To Do? Rename the variables  and rephrase the comment to reflect what was mention above

      Attachments

        Issue Links

          For Gerrit Dashboard: QTBUG-125756
          # Subject Branch Project Status CR V

          Activity

            People

              qtandroidteam Qt Android Team
              assam Assam Boudjelthia
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes