Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-95069 Add HTTP/2 support to Qt HTTP server
  3. QTBUG-126033

Add precheck before writing to QHttp2Stream in HTTP2 handler's write methods

    XMLWordPrintable

Details

    • Technical task
    • Resolution: Fixed
    • Not Evaluated
    • None
    • Qt Http Server
    • None
    • Foundation Sprint 69, Foundation Sprint 70, Foundation Sprint 71, Foundation Sprint 72, Foundation Sprint 73, Foundation Sprint 74, Foundation Sprint 75, Foundation Sprint 76, Foundation Sprint 101, Foundations Sprint 102, Foundation Sprint 103, Foundation Sprint 104, Foundation Sprint 105, Foundation Sprint 106, Foundation Sprint 107, Foundation Sprint 108, Foundation Sprint 109, Foundation Sprint 110, Foundation Sprint 111, Foundation Sprint 112, Foundation Sprint 113, Foundation Sprint 114

    Description

      In QHttpServerHttp2ProtocolHandler::write methods, check if there is already an upload ongoing for the stream. QHttp2Stream doesn't support having write called while there is still something in progress.

      Link to the original review comment:
      https://codereview.qt-project.org/c/qt/qthttpserver/+/564070/comment/a1db54d8_92155f1b/

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            lenabiliaieva Olena Biliaieva
            lenabiliaieva Olena Biliaieva
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes