Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-126108

Port QStringConverter lookup API to QAnyStringView encoding names

    XMLWordPrintable

Details

    • 1
    • 737c6680b (dev), b3edce58e (dev), f6c11ac4f (dev), d4c4e6b87 (dev), 002695527 (6.8), 09c3e9da1 (6.8), 23013db67 (6.8)
    • Foundation Sprint 109

    Description

      The QStringConverter encoding names keys were {{const char*}}s in 6.7, and we recently got a QString overload for them. But these names are only ever used to look stuff up in a lookup table, so this API is a perfect candidate for replacing all of these overload sets with a single QAnyStringView function.

      The ICU backend may need to be pessimized a bit, if there's no way to look up an encoding by anything other than a NUL-terminated string (but we can make NUL-termination quicker by using an SSO'ed std::string or QVLA<char>.

      Attachments

        Issue Links

          resulted in

          Task - A task that needs to be done. QTBUG-126109 De-pessimize QStringConverter QAnyStringView API

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Open
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              mmutz Marc Mutz
              mmutz Marc Mutz
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: