Details
-
Task
-
Resolution: Fixed
-
P0: Blocker
-
None
-
None
-
1
-
737c6680b (dev), b3edce58e (dev), f6c11ac4f (dev), d4c4e6b87 (dev), 002695527 (6.8), 09c3e9da1 (6.8), 23013db67 (6.8)
-
Foundation Sprint 109
Description
The QStringConverter encoding names keys were {{const char*}}s in 6.7, and we recently got a QString overload for them. But these names are only ever used to look stuff up in a lookup table, so this API is a perfect candidate for replacing all of these overload sets with a single QAnyStringView function.
The ICU backend may need to be pessimized a bit, if there's no way to look up an encoding by anything other than a NUL-terminated string (but we can make NUL-termination quicker by using an SSO'ed std::string or QVLA<char>.
Attachments
Issue Links
- resulted in
-
-
- Closed
-
| For Gerrit Dashboard: QTBUG-126108 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 566333,4 | QStringConverter: port encodingForName() to QAnyStringView | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 566334,4 | QStringConverter: port (name, Flags) ctor to QAnyStringView | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 566335,5 | QStringEn/Decoder: port (name, Flags) ctors to QAnyStringView | dev | qt/qtbase | Status: MERGED | +2 | +1 |
| 567282,2 | QStringConverter: port encodingForName() to QAnyStringView | 6.8 | qt/qtbase | Status: MERGED | +2 | 0 |
| 567285,2 | QStringConverter: port (name, Flags) ctor to QAnyStringView | 6.8 | qt/qtbase | Status: MERGED | +2 | 0 |
| 567286,2 | QStringEn/Decoder: port (name, Flags) ctors to QAnyStringView | 6.8 | qt/qtbase | Status: MERGED | +2 | 0 |