Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-126454

[REG 6.7 -> 6.8] Broken ABI due to missing QPageLayout::setBottomMargin(qreal)

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P1: Critical P1: Critical
    • 6.8.0
    • 6.8.0 Beta1
    • GUI: Painting
    • None
    • ad922bbac1d65ff044c63160c73324fa27f44793

      As part of print: Clamp margins entered by the user in the page setup dialog (514317) ยท Gerrit Code Review, bool QPageLayout::setBottomMargin(qreal bottomMargin) was expanded to take a second OutOfBoundsPolicy argument.

      To preserve ABI, all changed methods were added to src/gui/compat/removed_api.cpp:

      bool QPageLayout::setMargins(const QMarginsF &margins)
{
    return setMargins(margins, OutOfBoundsPolicy::Reject);
}

bool QPageLayout::setLeftMargin(qreal leftMargin)
{
    return setLeftMargin(leftMargin, OutOfBoundsPolicy::Reject);
}

bool QPageLayout::setRightMargin(qreal rightMargin)
{
    return setRightMargin(rightMargin, OutOfBoundsPolicy::Reject);
}

bool QPageLayout::setTopMargin(qreal topMargin)
{
    return setTopMargin(topMargin, OutOfBoundsPolicy::Reject);
}

      ...except that setBottomMargin is not there, causing:

      undefined symbol: _ZN11QPageLayout15setBottomMarginEd, version Qt_6

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            vgt Eirik Aavitsland
            the compiler Florian Bruhin
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes