Details
-
Technical task
-
Resolution: Unresolved
-
P2: Important
-
None
-
None
-
6a1557b41 (dev), 60a502722 (dev), feb6334f7 (6.8), 97bd4b65f (6.8)
Description
Controls symbol visibility of generated code.
https://codereview.qt-project.org/c/qt/qtwayland/+/544539 - client: Add CMake options to control visibility of generated symbols
https://doc-snapshots.qt.io/qt6-dev/qt-generate-wayland-protocol-client-sources.html
Signature
```cmake
qt_generate_wayland_protocol_client_sources(target
[PUBLIC_CODE | PRIVATE_CODE]
FILES file1.xml [file2.xml ...])
```
Is documented.
NO example snippet.
Has "since qt version" blurb.
Not TP.
Missing link to doc page from cmake manual command reference
https://doc-snapshots.qt.io/qt6-dev/cmake-command-reference.html
Same for the counterpart `qt_generate_wayland_protocol_server_sources`, patch pending.
*Notes:*
*Action points:*
AP: Add since qt version: Done, already there
AP: Add example snippet Done, there is a link to a different page with examples
AP: Add missing link to doc page Done
AP: Ask maintainers if it makes sense to introduce a new cmake policy to swap the default to use `PRIVATE_CODE`
Attachments
Gerrit Reviews
For Gerrit Dashboard: QTBUG-126471 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
569278,4 | CMake: Add wayland cmake commands to the manual command reference | dev | qt/qtdoc | Status: MERGED | +2 | 0 |
575935,2 | CMake: Add wayland cmake commands to the manual command reference | 6.8 | qt/qtdoc | Status: MERGED | +2 | 0 |
576018,3 | CMake: doc: Move 'since qt version' below find_package | dev | qt/qtwayland | Status: MERGED | +2 | 0 |
576141,2 | CMake: doc: Move 'since qt version' below find_package | 6.8 | qt/qtwayland | Status: MERGED | +2 | 0 |