Details
-
Bug
-
Resolution: Fixed
-
P1: Critical
-
6.7.2
-
None
-
61ddd6a19 (dev), 9fc1bb8b9 (dev), 660d3338d (6.8), 3a5467e17 (6.8), 261bd1808 (6.7), 047fcf47b (6.7), 77958f814 (tqtc/lts-6.5)
Description
In commit https://codereview.qt-project.org/c/qt/qttools/+/295830, lupdate was ported from QRegExp to QRegularExpression.
Before that change, a pattern like
TR_EXCLUDE += /home/egon/dev/vcpkg/installed/x64-linux/include/*
Would exclude files in the directory /home/egon/dev/vcpkg/installed/x64-linux/include and all subdirectories.
The internal regular expression object looked like this:
QRegExp(patternSyntax=1, pattern='"/home/egon/dev/vcpkg/installed/x64-linux/include/*"')
After the said change, the produced regular expression would match only the directory because the regular expression is anchored:
QRegularExpression("\\A(?:/home/egon/dev/vcpkg/installed/x64-linux/include/[^/]*)\\z", QRegularExpression::PatternOptions("NoPatternOption"))
This makes the usage of QMake's TR_EXCLUDE and CMake's QT_EXCLUDE_SOURCES_FROM_TRANSLATION needlessly laborsome. See this comment in QTBUG-27936 for an example
Attachments
Issue Links
- relates to
-
QTBUG-126040 QT_EXCLUDE_SOURCES_FROM_TRANSLATION not working as expected
- Closed
-
QTBUG-27936 Regression: lupdate is very very slow
- Closed
For Gerrit Dashboard: QTBUG-127146 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
576653,7 | lupdate: Make exclude patterns less strict again | dev | qt/qttools | Status: MERGED | +2 | 0 |
576790,5 | lupdate: Add failing test for a bug in exclusion handling | dev | qt/qttools | Status: MERGED | +2 | 0 |
577109,2 | lupdate: Add failing test for a bug in exclusion handling | 6.8 | qt/qttools | Status: MERGED | +2 | 0 |
577161,2 | lupdate: Make exclude patterns less strict again | 6.8 | qt/qttools | Status: MERGED | +2 | 0 |
577176,2 | lupdate: Add failing test for a bug in exclusion handling | 6.7 | qt/qttools | Status: MERGED | +2 | 0 |
577177,4 | lupdate: Make exclude patterns less strict again | 6.7 | qt/qttools | Status: MERGED | +2 | +1 |
577580,4 | lupdate: Make exclude patterns less strict again | tqtc/lts-6.5 | qt/tqtc-qttools | Status: MERGED | +2 | +1 |