Details
-
Bug
-
Resolution: Fixed
-
P1: Critical
-
6.6.3, 6.7.2
-
None
-
0dfb177b4 (dev), 1a787500b (6.8), 30512b70e (6.7), 034dc8983 (tqtc/lts-6.5)
Description
Saving WebP detaches the QImage when using WebP API. `.bits()` is called instead of `.constBits()` which leads to worse performance when QImage is already in required format.
Moreover if we have custom (larger) bytes per line, after detaching the image will be copied to a smaller bytes per line (additional data padding removed), so it'll crash (the bytes per line is read and passed to WebP API before detaching).
Attachments
| For Gerrit Dashboard: QTBUG-127540 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 581009,3 | webp: Fix potential oob access and needless detach when storing image | dev | qt/qtimageformats | Status: MERGED | +2 | 0 |
| 581075,2 | webp: Fix potential oob access and needless detach when storing image | 6.8 | qt/qtimageformats | Status: MERGED | +2 | 0 |
| 581174,2 | webp: Fix potential oob access and needless detach when storing image | 6.7 | qt/qtimageformats | Status: MERGED | +2 | 0 |
| 581219,2 | webp: Fix potential oob access and needless detach when storing image | tqtc/lts-6.5 | qt/tqtc-qtimageformats | Status: MERGED | +2 | 0 |