Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-127626

Port qtslib.cpp away from deprecated Q_DECLARE_LOGGING

    XMLWordPrintable

Details

    Description

      When compiling current gerrit/dev, I get

      [644/4380] Building CXX object src/platformsupport/input/CMakeFiles/InputSupportPrivate.dir/tslib/qtslib.cpp.o
      In file included from /home/marc/Qt/qtbase-submit-build/include/QtCore/qloggingcategory.h:1,
                       from /home/marc/Qt/qtbase-submit-build/include/QtCore/QLoggingCategory:1,
                       from /home/marc/Qt/qtbase-submit/src/platformsupport/input/tslib/qtslib.cpp:9:
      /home/marc/Qt/qtbase-submit/src/platformsupport/input/tslib/qtslib.cpp: In constructor ‘QTsLibMouseHandler::QTsLibMouseHandler(const QString&, const QString&, QObject*)’:
      /home/marc/Qt/qtbase-submit/src/corelib/io/qloggingcategory.h:168:67: warning: ‘const QLoggingCategory& qLcTsLib() [with <template-parameter-1-1> = void]’ is deprecated: Use Q_STATIC_LOGGING_CATEGORY or add either Q_DECLARE_LOGGING_CATEGORY or QT_DECLARE_EXPORTED_QT_LOGGING_CATEGORY in a header [-Wdeprecated-declarations]
        168 |     for (QLoggingCategoryMacroHolder<level> qt_category((category)()); qt_category; qt_category.control = false) \
            |                                                         ~~~~~~~~~~^~
      /home/marc/Qt/qtbase-submit/src/corelib/io/qloggingcategory.h:171:32: note: in expansion of macro ‘QT_MESSAGE_LOGGER_COMMON’
        171 | #define qCDebug(category, ...) QT_MESSAGE_LOGGER_COMMON(category, QtDebugMsg).debug(__VA_ARGS__)
            |                                ^~~~~~~~~~~~~~~~~~~~~~~~
      /home/marc/Qt/qtbase-submit/src/platformsupport/input/tslib/qtslib.cpp:28:5: note: in expansion of macro ‘qCDebug’
         28 |     qCDebug(qLcTsLib) << "Initializing tslib plugin" << key << specification;
            |     ^~~~~~~
      /home/marc/Qt/qtbase-submit/src/platformsupport/input/tslib/qtslib.cpp:20:20: note: declared here
         20 | Q_LOGGING_CATEGORY(qLcTsLib, "qt.qpa.input")
            |                    ^~~~~~~~
      /home/marc/Qt/qtbase-submit/src/corelib/io/qloggingcategory.h:143:29: note: in definition of macro ‘Q_LOGGING_CATEGORY’
        143 |     const QLoggingCategory &name() { return QtPrivateLogging::name(); }
            |                             ^~~~
      /home/marc/Qt/qtbase-submit/src/corelib/io/qloggingcategory.h:168:67: warning: ‘const QLoggingCategory& qLcTsLib() [with <template-parameter-1-1> = void]’ is deprecated: Use Q_STATIC_LOGGING_CATEGORY or add either Q_DECLARE_LOGGING_CATEGORY or QT_DECLARE_EXPORTED_QT_LOGGING_CATEGORY in a header [-Wdeprecated-declarations]
        168 |     for (QLoggingCategoryMacroHolder<level> qt_category((category)()); qt_category; qt_category.control = false) \
            |                                                         ~~~~~~~~~~^~
      /home/marc/Qt/qtbase-submit/src/corelib/io/qloggingcategory.h:171:32: note: in expansion of macro ‘QT_MESSAGE_LOGGER_COMMON’
        171 | #define qCDebug(category, ...) QT_MESSAGE_LOGGER_COMMON(category, QtDebugMsg).debug(__VA_ARGS__)
            |                                ^~~~~~~~~~~~~~~~~~~~~~~~
      /home/marc/Qt/qtbase-submit/src/platformsupport/input/tslib/qtslib.cpp:38:5: note: in expansion of macro ‘qCDebug’
         38 |     qCDebug(qLcTsLib) << "tslib device is" << ts_get_eventpath(m_dev);
            |     ^~~~~~~
      /home/marc/Qt/qtbase-submit/src/platformsupport/input/tslib/qtslib.cpp:20:20: note: declared here
         20 | Q_LOGGING_CATEGORY(qLcTsLib, "qt.qpa.input")
            |                    ^~~~~~~~
      /home/marc/Qt/qtbase-submit/src/corelib/io/qloggingcategory.h:143:29: note: in definition of macro ‘Q_LOGGING_CATEGORY’
        143 |     const QLoggingCategory &name() { return QtPrivateLogging::name(); }
            |                             ^~~~
      

      I'd fix it myself, but a) no time and b) the identifier and the string representation of the category seem to have a different scope, so I'd appreciate a domain export to fix it.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            kkohne Kai Köhne
            mmutz Marc Mutz
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes