Details
-
Bug
-
Resolution: Fixed
-
P2: Important
-
6.9
-
None
-
-
4baa3b7c5 (dev), b14891e3d (dev)
Description
The QML language server causes compiler warnings due to multiple comparisons of signed and unsigned integer variables.
One example in qqmllsutils.cpp:294
const auto smallestColon = smallest->fileLocation->info().regions[ColonTokenRegion]; // sanity check: is it the definition of the current binding? check if they both have their // ':' at the same location if (propertyDefinitionColon.isValid() && propertyDefinitionColon == smallestColon && offsetInFile < smallestColon.offset) { return smallestPropertyDefinition; }
offsetInFile is a qsizetype, while smallesColon.offset is a qint32.
Side note: The definition of smallestColon using auto is inappropriate, because the type is not obvious at this point.