Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-128812

QProtobufJsonSerializer and QProtobufSerializer should share their code base, but not copy the functionality

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • P2: Important
    • None
    • 6.9
    • Protocol Buffers
    • None
    • c344407f8 (dev), 891d89e53 (6.8), 11f053d77 (dev), 86934243b (6.8)
    • Foundation PM Staging

    Description

      We established the clear and simple interface for QAbstractProtobufSerializer in Qt 6.8, but the QProtobufJsonSerializer and QProtobufSerializer implementations still are not clean. They have a lot of code duplication, so we should resolve this and clean the code.

      Attachments

        Issue Links

          is required for

          User Story - Created by Jira Software - do not edit or delete. Issue type for a user story. QTBUG-129161 Various enhancements in Qt gRPC and Protobuf

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Open
          For Gerrit Dashboard: QTBUG-128812
          # Subject Branch Project Status CR V
          593729,41 Generalize serialization in protobuf and JSON serializers dev qt/qtgrpc Status: NEW 0 0
          594252,32 Generalize deserializer in protobuf and JSON serializers dev qt/qtgrpc Status: NEW 0 0
          594395,25 Move the scalar protobuf type serializer to a seprate TU dev qt/qtgrpc Status: NEW 0 0
          594396,25 Make QProtobufJsonSerializerPrivate ctor out-of-line dev qt/qtgrpc Status: NEW +2 0
          594397,26 Use the if_json_floating_point as isPresent trait dev qt/qtgrpc Status: NEW +2 0
          595002,16 Make serializeVarintCommon SCARY dev qt/qtgrpc Status: NEW +2 0
          595003,16 Pass the argument of serializeVarintCommon by value dev qt/qtgrpc Status: NEW +2 0
          595004,16 Remove the useless variable initialization when serializing zigzag int dev qt/qtgrpc Status: NEW +2 0
          595005,16 Reuse the serializedList variable in serializeListType dev qt/qtgrpc Status: NEW +2 0
          595006,15 Deduplicate the iterator increasing in deserializeVarintCommon dev qt/qtgrpc Status: NEW +2 0
          595007,16 Replace std::optional::value with std::optional::operator * dev qt/qtgrpc Status: NEW +2 0
          595049,16 Simplify deserializeBasic for signed varints dev qt/qtgrpc Status: NEW +2 0
          595050,12 Small optimization bit in deserializeVarintCommon dev qt/qtgrpc Status: NEW +2 0
          595051,11 Move string literals out of template function definitions dev qt/qtgrpc Status: NEW +2 0
          595052,11 Use case insensitive QByteArray::compare where applicable dev qt/qtgrpc Status: NEW +2 0
          598502,4 Avoid potential runtime stack allocation of variable in deserializeBasic dev qt/qtgrpc Status: NEW +2 0
          598507,7 Avoid looking for scalar type deserializer twice dev qt/qtgrpc Status: NEW +2 0
          598632,4 Deduplicate preserveUnknownFields variable dev qt/qtgrpc Status: NEW +2 0
          599194,7 Protobuf: Add JSON deserializer benchmark dev qt/qtgrpc Status: NEW +2 0

          Activity

            People

              semlanik Alexey Edelev
              semlanik Alexey Edelev
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There are 19 open Gerrit changes