Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-128942

parseBlackList() sheds line's capacity() d/t simplified() call

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • P4: Low
    • None
    • 6.9
    • Testing: qtestlib
    • None
    • 2

    Description

      The parseBlackList() in src/testlib/qtestblacklist.cpp was ported to QIODevice::readLineInto() recently. This function is most effective when the following loop does not modify the arguments' capacity(). The one in parseBlackList() does (line = line.simplified(). Find out whether the simplified() is actually needed, or checkCondition() can be modified to treat arbitrary whitespace internally instead. Port the whole thing to QByteArrayView.

      Reference: https://codereview.qt-project.org/c/qt/qtbase/+/582735/comment/fe8a41f7_e6476a86/

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            macadder Jason McDonald
            mmutz Marc Mutz
            Vladimir Minenko Vladimir Minenko
            Alex Blasche Alex Blasche
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes