-
Task
-
Resolution: Unresolved
-
Not Evaluated
-
None
-
None
-
None
This task covers the list of changes that we made to support building chromium with system libraries. Identify them and try to reduce their number if possible.
There are 4 categories:
* Unbundle changes: patching the BUILD.gn files of a library (mostly adds a pkg-config and a shim-header call)
* Fixes for building with system libs: patching .h and .cc files to fix api changes of the lib
* Build script fixes: patching pkg-config and shim-header templates and scripts
* qt3rdparty libs: same as Unbundle but for qt's libs
The Unbundle changes could be squashed, because we use the same pattern for every file e.g.: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/186118 . These changes rarely need fixups.
The build fixes should have separate changes for each library. There are 3-4 libs which need these fixes frequently e.g.: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/427771 .
The script fixes are small and probably could fit into the Unbundle patch, but some of them targeting a specific issue and and maybe better to let alone. e.g: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/256785 and https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/529211
The qt3rdparty libs changes could be squashed for same reason as the Unbundle changes.
Unbundle changes | |
---|---|
eeccfe807ae | Improve jpeg headers handling |
1209cf45261 | Optionally unbundle libvpx, opus, FLAC, re2 and OpenH264 |
ea2737930d2 | Add missing pkg_config calls for system libs |
862f78190ea | Unbundle Linux system libraries for GN |
97c9f8d0b71 | Optionally link with system ICU |
1b09e99ab20 | Add pdfium_use_system_libtiff build option |
be4cd754e6f | Optionally link with system ffmpeg |
4e73d80fafc | FIXUP: Optionally link with system ICU |
Build fixes | |
a15afa826c5 | Fix building with system libxml2 |
7c0db5d7cef | Fix building with system ffmpeg |
Script fixes | |
994f7217e4c | Accept system_libdir with mulit-paths for pkg-config.py |
b9f8d92ad15 | Use pkg-config on mac if found |
2621e3c2875 | Allow shims in official builds |
f785a68cedf | Fix incorrect dependency on shim headers |
qt3rdparty libs | |
6a12854a362 | Add qt static dependencies: qtlibjpeg |
b6a2f088f91 | Add qt static dependencies: qtlibpng |
b4b8be88a72 | Add qt static dependencies: qtfreetype, qtharfbuzz |
064fd50eefe | Add qt static dependencies: qtzlib |
c405c37ea4d | Fix static build with qt3rdparty libs |
For Gerrit Dashboard: QTBUG-130121 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
667970,1 | [unbundle] [revert] Revert changes related to unbundled system libs | 134-based | qt/qtwebengine-chromium | Status: NEW | 0 | 0 |
667971,1 | [unbundle] Unbundle Linux system libraries for GN | 134-based | qt/qtwebengine-chromium | Status: NEW | 0 | 0 |
667972,1 | [unbundle] Fix building with system ICU | 134-based | qt/qtwebengine-chromium | Status: NEW | 0 | 0 |
667973,1 | [unbundle] Fix building with system libvpx | 134-based | qt/qtwebengine-chromium | Status: NEW | 0 | 0 |