Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-130703

Fix casting of EGLNativeDisplayType, EGLNativeWindowType, EGLNativePixmapType

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • P4: Low
    • None
    • 6.9
    • QPA: EGLFS
    • None

    Description

      The EGLNativeDisplayType, EGLNativeWindowType, EGLNativePixmapType types should be cast using proper C++ casts, due to their definition in EGL/eglplatform.h being:

      #define EGLNativeDisplayType void *
      #define EGLNativeWindowType void *
      #define EGLNativePixmapType void *
      

      This leads to function-style casts, e.g. EGLNativeDisplayType(quintptr(defaultDisplay)), expanding to invalid code, void *(quintptr(defaultDisplay)) and breaking compilation. This needs a reinterpret_cast to work sensibly.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            gscheibel Glenn Scheibel
            arpa Ari Parkkila
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes