Details
-
Suggestion
-
Resolution: Unresolved
-
P3: Somewhat important
-
None
-
None
-
7c5cb036a (dev), 028f59ef2 (dev), e557bba77 (dev), 36218f25d (dev), c5ac46137 (dev), 9db54bd47 (dev), 266c20ec0 (dev)
Description
- MOST of the times (for read def) we use just INFO and we don't need subItems tree or whatever
- QMap<Path, Ptr> m_subItems; ← Typically only subpart of the Path, like "[""]" or ".objects" or smth else. maybe it's actually PathComponent-s
- Looks like foundTreePath and rootTreePath could be removed.....
- Remove ensureItemAtPath ?? same as infoAtPath ? Which I assume thought to be static at some point?
Why AttachedInfo and FileLocations must be aligned hierarchicaly with the Path hiearachy? Like When looking for a AttachedInfo<FileLocation> it's not just map Path - Info, it's tress, where each Node has Subitems etc. Like whatever we modify we are structurally(a.k.a. Path defined) valid?
What we need in most cases just a simple hash map <Path - FileLocations> ?{}
Attachments
Gerrit Reviews
For Gerrit Dashboard: QTBUG-130710 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
601957,16 | QmlDom: remove redundant things related to AttributeInfo and FileLocations | dev | qt/qtdeclarative | Status: MERGED | +2 | +1 |
602058,6 | WIP: move fileLocations specific lookup from generic AttachedInfo | dev | qt/qtdeclarative | Status: ABANDONED | -2 | 0 |
602079,6 | WIP: remove redundant AttachedInfoLookupResultBase | dev | qt/qtdeclarative | Status: ABANDONED | -2 | 0 |
602080,8 | WIP merge FileLocations::findAttachedInfo into FileLocations::treeOf | dev | qt/qtdeclarative | Status: ABANDONED | -2 | 0 |
602081,12 | QmlDom: simplify AttachedInfo and FileLocations lookup | dev | qt/qtdeclarative | Status: MERGED | +2 | +1 |
602681,13 | QmlDom: simplify AttachedInfo | dev | qt/qtdeclarative | Status: MERGED | +2 | +1 |
603698,8 | QmlDom: Dissolve FileLocations into a namespace and FileLocations::Info | dev | qt/qtdeclarative | Status: MERGED | +2 | +1 |
603729,4 | QmlDom: merge AttachedInfoT into AttachedInfo | dev | qt/qtdeclarative | Status: ABANDONED | 0 | +1 |
603745,7 | QmlDom: AttachedInfo -> FileLocations::Node | dev | qt/qtdeclarative | Status: MERGED | +2 | +1 |
603746,6 | QmlDom rename attachedinfo file to filelocations | dev | qt/qtdeclarative | Status: MERGED | +2 | 0 |
604373,10 | QmlDom improve reliability of FileLocations | dev | qt/qtdeclarative | Status: MERGED | +2 | 0 |