Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-131094

Clean up "Adapt favicon and history component"

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • P3: Somewhat important
    • None
    • 6.8, 6.9
    • WebEngine
    • None

    Description

      Reported to not forget: no dependacy on identity manager, but sadly headers included

      see:

      ./chromium/components/history/core/browser/web_history_service.cc

      #include "components/signin/public/identity_manager/access_token_info.h"
      #include "components/signin/public/identity_manager/identity_manager.h"
      #include "components/signin/public/identity_manager/primary_account_access_token_fetcher.h"
      #include "components/signin/public/identity_manager/scope_set.h"

      and

      chromium/components/history/core/browser/BUILD.gn

      deps -= [
      "//components/crash/core/common:crash_key",
      "//components/database_utils",
      "//components/google/core/common",
      "//components/search_engines",
      "//components/signin/public/identity_manager",
      "//components/sync",
      ]

      Attachments

        For Gerrit Dashboard: QTBUG-131094
        # Subject Branch Project Status CR V

        Activity

          People

            qt_webengine_team Qt WebEngine Team
            michal Michal Klocek
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There is 1 open Gerrit change