Details
-
Bug
-
Resolution: Fixed
-
P2: Important
-
6.9
-
None
-
3
-
4a3fc66b8 (dev), ae39ec18b (6.8)
-
Foundation Sprint 121, Foundation Sprint 122
Description
We generate two ways for the include guards: pragma and header guards. The latter approach has some problems though as it struggles with dashes "-" in the filename, e.g. "my-proto.proto". We could transform this into a valid C-identifier, e.g. "MY_PROTO..." but how would we handle the case where we have "my-proto.proto" and "my_proto.proto" in the same project?
We should either fix the header guards approach for this edge case or switch to "#pragma once" as the default and deprecate header guards in the upcoming releases. Current state with a partly broken default is not nice.
Attachments
Issue Links
- is required for
-
QTBUG-129161 Various enhancements in Qt gRPC and Protobuf
-
- In Progress
-
For Gerrit Dashboard: QTBUG-131417 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
609649,4 | generator: handle invalid identifier(s) in filename | dev | qt/qtgrpc | Status: MERGED | +2 | 0 |
609731,5 | generator: handle invalid identifier(s) in filename | 6.8 | qt/qtgrpc | Status: MERGED | +2 | +1 |