Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-131922

Refactor OAuth2 autotest cases

    XMLWordPrintable

Details

    • Task
    • Resolution: Done
    • P2: Important
    • None
    • None
    • Network: Authentication
    • None
    • All
    • 13
    • e0738a5e7 (dev), e61698bb9 (dev), d1c168f97 (dev), 9b5d12bff (dev), fd5d3e97a (dev), e1c356a11 (dev), 0ba0f6890 (dev), d57ff1f13 (dev), 365eb9964 (dev), 45809dfc2 (dev), b93c36b0d (dev), 0ae3ea9d8 (dev), 909eec11f (6.9), a51845079 (6.9), 47ce0f65f (6.9)
    • Foundation Sprint 121, Foundation Sprint 122, Foundation Sprint 123, Foundation Sprint 124

    Description

      tst_oauth2 and tst_deviceflow have many things in common, but sharing them is not trivial, or more aptly put, results in messy autotest code with a lot of if/elses.

      However the test cases should be finegroomed if more can be shared. Possibly a new tst_authorizationcodeflow test should be introduced, and the tst_oauth2 should just focus on testing abstract oauth2 setters.

      Without such refactorings, the autotests are (increasingly) hard to maintain, and contain unnecessary duplication and work effort in the long term.

      Attachments

        Issue Links

          resulted from

          Task - A task that needs to be done. QTBUG-130844 [OAuth] Post "Qt 6.9 FF" items for Device Authorization Flow support

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          split from

          Task - A task that needs to be done. QTBUG-130844 [OAuth] Post "Qt 6.9 FF" items for Device Authorization Flow support

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          For Gerrit Dashboard: QTBUG-131922
          # Subject Branch Project Status CR V
          617797,8 Rename tst_oauth2 test to tst_oauth2codeflow dev qt/qtnetworkauth Status: MERGED +2 0
          617798,8 Add dedicated autotest for QAbstractOAuth2 dev qt/qtnetworkauth Status: MERGED +2 0
          617799,9 Move autoRefresh(), and tokenUrl() common parts into tst_abstractoauth2 dev qt/qtnetworkauth Status: MERGED +2 0
          617800,9 Move sslConfig() and invalidLeadTime() to tst_abstractoauth2 dev qt/qtnetworkauth Status: MERGED +2 0
          617801,9 Move nonce() common parts to tst_abstractoauth2.cpp dev qt/qtnetworkauth Status: MERGED +2 0
          617802,9 Move prepareRequest() to tst_abstractoauth2 dev qt/qtnetworkauth Status: MERGED +2 0
          619138,6 Make webserver and tlswebserver autotest utilities not a header-only dev qt/qtnetworkauth Status: MERGED +2 0
          619140,9 Introduce shared autotest authorization server dev qt/qtnetworkauth Status: MERGED +2 0
          619141,9 Make tst_oauth2deviceflow to use shared authorization server dev qt/qtnetworkauth Status: MERGED +2 0
          619142,9 Make tst_oauth2codeflow to use shared authorization server dev qt/qtnetworkauth Status: MERGED +2 0
          621237,2 Move setInvalidScope() autotest to tst_abstractoauth2 dev qt/qtnetworkauth Status: MERGED +2 0
          621238,2 Move scopeCharacterWarnings() autotest to tst_abstractoauth2 dev qt/qtnetworkauth Status: MERGED +2 0
          621459,4 Simplify and move scopeAndRequestedScope() test to tst_abstractoauth2 dev qt/qtnetworkauth Status: MERGED +2 0
          621577,2 Make webserver and tlswebserver autotest utilities not a header-only 6.9 qt/qtnetworkauth Status: MERGED +2 0
          621578,2 Rename tst_oauth2 test to tst_oauth2codeflow 6.9 qt/qtnetworkauth Status: MERGED +2 0
          621579,2 Add dedicated autotest for QAbstractOAuth2 6.9 qt/qtnetworkauth Status: MERGED +2 0
          621580,2 Move autoRefresh(), and tokenUrl() common parts into tst_abstractoauth2 6.9 qt/qtnetworkauth Status: MERGED +2 0
          621581,2 Move sslConfig() and invalidLeadTime() to tst_abstractoauth2 6.9 qt/qtnetworkauth Status: MERGED +2 0
          621582,2 Move nonce() common parts to tst_abstractoauth2.cpp 6.9 qt/qtnetworkauth Status: MERGED +2 0
          621583,2 Move prepareRequest() to tst_abstractoauth2 6.9 qt/qtnetworkauth Status: MERGED +2 0
          621584,2 Introduce shared autotest authorization server 6.9 qt/qtnetworkauth Status: MERGED +2 0
          621585,2 Make tst_oauth2deviceflow to use shared authorization server 6.9 qt/qtnetworkauth Status: MERGED +2 0
          621586,2 Make tst_oauth2codeflow to use shared authorization server 6.9 qt/qtnetworkauth Status: MERGED +2 0
          621589,2 Move setInvalidScope() autotest to tst_abstractoauth2 6.9 qt/qtnetworkauth Status: MERGED +2 0
          621590,2 Move scopeCharacterWarnings() autotest to tst_abstractoauth2 6.9 qt/qtnetworkauth Status: MERGED +2 0
          621687,2 Simplify and move scopeAndRequestedScope() test to tst_abstractoauth2 6.9 qt/qtnetworkauth Status: MERGED +2 0

          Activity

            People

              vuokko Juha Vuolle
              vuokko Juha Vuolle
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes