Details
-
Bug
-
Resolution: Fixed
-
P1: Critical
-
6.9 FF
-
None
-
529ebb317 (dev), 2a512fd90 (6.9), 4f05eac0a (dev), a256dba80 (6.9)
Description
I get compile errors from a -unity-build with a large batch size now:
In file included from qloggingcategory.h:1,
from qcoreapplication_p.h:28,
from qcoreapplication_p.h:1,
from qlibraryinfo.cpp:778,
from unity_0_cxx.cxx:28:
qloggingcategory.h:113:11: error: reference to ‘QtPrivateLogging’ is ambiguous
113 | using QtPrivateLogging::name;
| ^~~~~~~~~~~~~~~~
qsocketnotifier.cpp:23:1: note: in expansion of macro ‘Q_DECLARE_LOGGING_CATEGORY’
23 | Q_DECLARE_LOGGING_CATEGORY(lcSocketNotifierDeprecation)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
qloggingcategory.h:107:15: note: candidates are: ‘namespace QtPrivate::QtPrivateLogging { }’
107 | namespace QtPrivateLogging { export_macro const QLoggingCategory &name(); } \
| ^~~~~~~~~~~~~~~~
Looks like https://codereview.qt-project.org/c/qt/qtbase/+/235873 broke having Q_DECLARE_LOGGING_CATEGORY's in differing namespaces.
Attachments
For Gerrit Dashboard: QTBUG-132111 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
610885,6 | Use inline namespaces rather than "using" for logging categories | dev | qt/qtbase | Status: MERGED | +2 | 0 |
610914,3 | WIP: try inline namespace | dev | qt/qtbase | Status: ABANDONED | -2 | +1 |
611221,2 | Use inline namespaces rather than "using" for logging categories | 6.9 | qt/qtbase | Status: MERGED | +2 | 0 |
617289,4 | Core: Remove duplicate QtPrivate namespace | dev | qt/qtbase | Status: MERGED | +2 | 0 |
617567,2 | Core: Remove duplicate QtPrivate namespace | 6.9 | qt/qtbase | Status: MERGED | +2 | 0 |