Details
-
Bug
-
Resolution: Fixed
-
P2: Important
-
6.8.1
-
None
-
Arch Linux wayfire
-
Linux/Wayland
-
91462d28f (dev), 957834d52 (6.9), 883e4d262 (6.8)
Description
In zwp_text_input_v3_leave() there is a call to disable(), but it's not committed. This causes wlroots to not emit the enable event afterwards and so some compositor (e.g. wayfire) no longer enable input method.
diff --git a/src/client/qwaylandtextinputv3.cpp b/src/client/qwaylandtextinputv3.cpp
index c4bfebe3..9254cf12 100644
--- a/src/client/qwaylandtextinputv3.cpp
+++ b/src/client/qwaylandtextinputv3.cpp
@@ -69,6 +69,7 @@ void QWaylandTextInputv3::zwp_text_input_v3_leave(struct ::wl_surface *surface)
m_surface = nullptr;
disable();
+ commit();
qCDebug(qLcQpaWaylandTextInput) << Q_FUNC_INFO << "Done";
}
Attachments
| For Gerrit Dashboard: QTBUG-132195 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 617769,2 | textinputv3: need to commit() after disable() | dev | qt/qtwayland | Status: MERGED | +2 | 0 |
| 618093,2 | textinputv3: need to commit() after disable() | 6.9 | qt/qtwayland | Status: MERGED | +2 | 0 |
| 618116,2 | textinputv3: need to commit() after disable() | 6.8 | qt/qtwayland | Status: MERGED | +2 | 0 |