Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-132307

The src directories should not contain anything other than headers and sources.

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Invalid
    • Icon: Not Evaluated Not Evaluated
    • None
    • None
    • Other
    • None

      Some other file types I have seen in source directories: CMakeLists.txt, .ico files, ...

      This is bad practice, since the src directory is meant for sources (and headers). Using it for any other purpose would qualify as bad naming. The CMakeLists.txt should be a sibling of the src directory, not a child. The icons should go to a resource folder along with other similar resources.

      We should additionally consider splitting the include and source directories in order to have the same file tree in build (include + source) and install (only include) directories. I would argue this is widespread, de-facto standard CMake/C++ practice by now.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            vhilshei Volker Hilsheimer
            ali.demiralp Ali Can Demiralp (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes