Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-132503

QSet::unite docs don't match implementation

    XMLWordPrintable

Details

    • 1
    • Foundation Sprint 122

    Description

      https://doc.qt.io/qt-6/qset.html#unite says:

      Each item in the other set that isn't already in this set is inserted into this set.

      This is not what the implementation does:

          for (const auto &e : std::as_const(other))
        insert(e);

      Since https://codereview.qt-project.org/c/qt/qtbase/+/531872, which set is *this and which is other is now "random". Created QTBUG-132500 to track that aspect of the problem.

      Once QTBUG-132500 is fixed, fix the docs to match the implementation again.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-132500 [REG 6.7 -> 6.8] QSet::unite() no longer consistently picks equivalent elements from `other`

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-132536 QSet::intersect() picks equivalent elements inconsistently from `other` or *this

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              mmutz Marc Mutz
              mmutz Marc Mutz
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes