Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-132724

`qt_internal_generate_user_facing_tools_info` is not relocatable

    XMLWordPrintable

Details

    • 6a4df2ac2 (dev), d45687f49 (6.9)

    Description

      Looking at the implementation, it seems that the symlinks generated are not created as relative paths:

              qt_path_join(tool_target_path "${CMAKE_INSTALL_PREFIX}" "${INSTALL_BINDIR}" "${filename}")
        qt_path_join(tool_link_path "${INSTALL_PUBLICBINDIR}" "${linkname}${PROJECT_VERSION_MAJOR}")
        list(APPEND lines "${tool_target_path} ${tool_link_path}")

      This should be an easy fix by calling cmake_path(RELATIVE_PATH)

      Attachments

        Issue Links

          relates to

          Suggestion - Public suggestions QTBUG-132761 Create the symbolic links in `user_facing_tool_links.txt` as part of the install process

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Reported
          For Gerrit Dashboard: QTBUG-132724
          # Subject Branch Project Status CR V
          619658,1 Make user tools symlinks relative 6.8 qt/qtbase Status: NEW +2 0

          Activity

            People

              lecris Cristian Le
              lecris Cristian Le
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There is 1 open Gerrit change