Loading...

XML

Word

Printable

Story Points:
3
Commits:
b80679a90 (dev), cd99c6aad (6.9), 66456f9aa (6.8), cf7cd0818 (tqtc/lts-6.5), 150d3e344 (tqtc/lts-6.2), 02118ed09 (tqtc/lts-5.15), 3a284dc19 (dev), 605a20b26 (6.9), 4299115fe (6.8), e1efc67bc (tqtc/lts-6.5)
Sprint:
Foundation Sprint 123, Foundation Sprint 124

QSet::remove() (via QHash::remove()) and removeIf() (via QtPrivate::set_erase_if()) detache from shared state even if nothing is being removed.

Expected behaviour: if remove() or removeIf() doesn't modify the container, then shared state is not detach()ed from.

For Gerrit Dashboard: QTBUG-132831
#	Subject	Branch	Project	Status	CR	V
616880,9	QSet: don't detach in remove()/removeIf() if nothing is being removed	dev	qt/qtbase	Status: MERGED	+2	0
617353,2	tst_QSet: check whether remove/removeIf detach if nothing is removed	dev	qt/qtbase	Status: MERGED	+2	+1
619253,2	tst_QSet: check whether remove/removeIf detach if nothing is removed	6.9	qt/qtbase	Status: MERGED	+2	0
619435,2	tst_QSet: check whether remove/removeIf detach if nothing is removed	6.8	qt/qtbase	Status: MERGED	+2	0
619614,2	tst_QSet: check whether remove/removeIf detach if nothing is removed	tqtc/lts-6.5	qt/tqtc-qtbase	Status: MERGED	+2	0
619681,2	tst_QSet: check whether remove/removeIf detach if nothing is removed	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
619899,3	tst_QSet: check whether remove/removeIf detach if nothing is removed	tqtc/lts-5.15	qt/tqtc-qtbase	Status: MERGED	+2	0
621693,2	QSet: don't detach in remove()/removeIf() if nothing is being removed	6.9	qt/qtbase	Status: MERGED	+2	0
621730,2	QSet: don't detach in remove()/removeIf() if nothing is being removed	6.8	qt/qtbase	Status: MERGED	+2	0
621825,2	QSet: don't detach in remove()/removeIf() if nothing is being removed	tqtc/lts-6.5	qt/tqtc-qtbase	Status: MERGED	+2	0