Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-132876

Add the range and sign check for the google.protobuf.Duration

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • P2: Important
    • None
    • 6.8
    • Protocol Buffers
    • None

    Description

      google.protobuf.Duration should invalidate the value in it's setter if it's out of range.

      Hint:

      message Duration {
        // Signed seconds of the span of time. Must be from -315,576,000,000
        // to +315,576,000,000 inclusive. Note: these bounds are computed from:
        // 60 sec/min * 60 min/hr * 24 hr/day * 365.25 days/year * 10000 years
        int64 seconds = 1;
      
        // Signed fractions of a second at nanosecond resolution of the span
        // of time. Durations less than one second are represented with a 0
        // `seconds` field and a positive or negative `nanos` field. For durations
        // of one second or more, a non-zero value for the `nanos` field must be
        // of the same sign as the `seconds` field. Must be from -999,999,999
        // to +999,999,999 inclusive.
        int32 nanos = 2;
      }
      

      Also it's natural to require nanoseconds and seconds to be the same sign.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            tatiana.borisova Tatiana Borisova
            semlanik Alexey Edelev
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes