Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-134194

[Coverity] QOpenGLEngineManager uninit'ed value

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • P2: Important
    • None
    • 6.9.0 Beta1
    • GUI: OpenGL

    Description

      Coverity¹ complains that, in QOpenGLEngineShaderManager::useCorrectShaderProg(), requiredProgram.compositionFragShader might be uninit'ed in L841, when calling sharedShaders->findProgramInCache(requiredProgram).

      Indeed, the switch (compositionMode) in L777...813 does not initialize that value in its default: case label (L811..812).

      Either we need to assign some no-op value in that case, or make the qWarning() a qCritical(), like it's done in L770, e.g.

      ¹ CID 390894 (https://scan3.scan.coverity.com/#/project-view/28157/10113?selectedIssue=390894)

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            lagocs Laszlo Agocs
            mmutz Marc Mutz
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes