Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-134425

Clarify the purpose of FEATURE_precompile_header

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P2: Important
    • 6.10.0 FF
    • 6.9
    • Build System: CMake
    • None
    • 9f86517cc (dev)

    Description

      The top level configure.cmake in qtbase has:

      qt_feature("precompile_header"
          LABEL "Using precompiled headers"
          CONDITION BUILD_WITH_PCH AND TEST_precompile_header
          AUTODETECT NOT WASM
      )
      

      but absolutely nothing uses FEATURE_precompile_header, only BUILD_WITH_PCH.

      This is suspicious. For instance, if the associated test fails, is the FEATURE going to be "off" but Qt would still be using PCH...?

      Attachments

        For Gerrit Dashboard: QTBUG-134425
        # Subject Branch Project Status CR V

        Activity

          People

            jbornema Joerg Bornemann
            peppe Giuseppe D'Angelo
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes