Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-134543

Benchmark QTriangulator and fix integral overflows, if needed

XMLWordPrintable

    • 536cd1ce2 (dev), af6a417ac (6.9), d4c80b3be (6.8), fcfeed5ee (tqtc/lts-6.5)

      While reviewing a fix¹ for Coverity-Id 11295, Eddy found² that from ca. 40'000 edges, integer overflow may occur.

      The question is whether the class can handle that many entries, or whether it would have bogged down the system by that time already.

      Investigate, and, if needed, fix.

      ¹ https://codereview.qt-project.org/c/qt/qtbase/+/628605
      ² https://codereview.qt-project.org/c/qt/qtbase/+/628605/comment/708ba348_62f4800b/

        For Gerrit Dashboard: QTBUG-134543
        # Subject Branch Project Status CR V
        628605,4 QTriangulator: make a primeForCount() precondition explicit dev qt/qtbase Status: MERGED +2 0
        633528,2 QTriangulator: make a primeForCount() precondition explicit 6.9 qt/qtbase Status: MERGED +2 0
        633894,2 QTriangulator: make a primeForCount() precondition explicit 6.8 qt/qtbase Status: MERGED +2 0
        633900,2 QTriangulator: make a primeForCount() precondition explicit tqtc/lts-6.5 qt/tqtc-qtbase Status: MERGED +2 0

            lagocs Laszlo Agocs
            mmutz Marc Mutz
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:

                There are no open Gerrit changes