Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-135471

tst_QXmlStream does not test non-wellformed documents properly

    XMLWordPrintable

Details

    • 8
    • 633278fe1 (dev), a0ed54cb0 (6.9), d9ba7bf55 (6.8), e9f0d00c4 (tqtc/lts-6.5), 6b26e2013 (tqtc/lts-5.15)
    • Foundation Sprint 128, Foundation Sprint 129

    Description

      At first I noticed that the incremental parsing was not working because the file was already at its end, so we were not reading any data.

      I created https://codereview.qt-project.org/c/qt/qtbase/+/636399 to address it.

      Later I also noticed that the code that was feeding the data byte-by-byte was always skipping the first byte. So, all the provided documents were treated as non-wellformed.

      After fixing it locally (see comment https://codereview.qt-project.org/c/qt/qtbase/+/636399/comment/5ab4c195_9d64cf2e/), I saw that six non-wellformed documents were treated as well-formed during the incremental parsing.

      The scope of this task is to fix the test and the parser to make sure that the incemental parsing also works correctly.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            ivan.solovev Ivan Solovev
            ivan.solovev Ivan Solovev
            Vladimir Minenko Vladimir Minenko
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes