Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-136781

Refactor QOpenSLESEngine class

    XMLWordPrintable

Details

    • User Story
    • Resolution: Fixed
    • P2: Important
    • None
    • 6.10.0
    • Multimedia
    • None
    • Android
    • Multimedia, weeks 18-19
    • 84672ba3c (dev), fc8071422 (dev), 8763eff68 (tqtc/lts-6.8), 8a3a81ff3 (6.9), 33c91c1f0 (6.9), 902f5b349 (6.9), ba160a3c5 (tqtc/lts-6.8), 2d25d98a9 (tqtc/lts-6.8), fc9c6d458 (tqtc/lts-6.8), 2d9481a1f (dev), edcefbe11 (6.9), 8846e39f1 (tqtc/lts-6.8)

    Description

      QOpenSLESEngine class needs refactoring.

      We should consider using QCachedValue for all supported format properties

      Also we should consider to support more than 6 channels

      [EDITED]

      I think it should be wrapped in a structure.

      struct InputConfig {
          channelsCount
          sampleFormats
          ...
      };
      

      And QCachedValue can be used for this structure in such a way:

      static InputConfig findInputConfig() {
          ....
      };
      
      QCachedValue<InputConfig> m_inputConfig;
      

      // update:

      m_inputConfig.ensure(&findInputConfig);

      Attachments

        Issue Links

          For Gerrit Dashboard: QTBUG-136781
          # Subject Branch Project Status CR V

          Activity

            People

              bartlomiejmoskal Bartlomiej Moskal
              bartlomiejmoskal Bartlomiej Moskal
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: