Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-137454

qmllint: revisit/optimize checking for required properties

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: P2: Important P2: Important
    • 6.11
    • None
    • QML: Tooling
    • None

      From the crash at https://bugreports.qt.io/browse/QTBUG-136998 and the patch at https://codereview.qt-project.org/c/qt/qtdeclarative/+/646875, it seems that we might want to revisit/optimize the required properties check in qmllint.

      We need to iterate over base types to find property definitions, property bindings and property requirements. We also need to search children of base types due to aliases to required properties. These two axes are currently mixed together and this causes issues. Especially with the scopesToSearch list.

      Maybe a better approach for all this would be to collect all properties, bindings, requirements and alises for each scope and only then perform the checks. This would also ensure that our warnings provide the necessary information. Right now we just hope that what we insert into the warning is correct. 

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            qtqmlteam Qt Qml Team User
            sami.shalayel Sami Shalayel
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                There are no open Gerrit changes