Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-138204 Implement QDataFunnel/Node
  3. QTBUG-138235

dataReady() & dataReceived() signal clarifications

    XMLWordPrintable

Details

    • Technical task
    • Resolution: Unresolved
    • Not Evaluated
    • None
    • None
    • None

    Description

      Currently, we use the dataReceived() signal as the notifier signal for the inputBuffer property, and dataReady() for the outputBuffer. However, this means we should emit then when ever the buffers change, and currently we only do that when something is written to them - but when they are cleared, the signals don't get emitted, even though the contents change. However, it feels somewhat unintuitive to emit a signal called dataReady() when the buffer is cleared, and same for the input one.

      We could add separate notifier signals for the buffers, and make sure to emit them also when the buffer is cleared, and leave the dataReady() and dataReceived() as convenience signals that are only emitted when data is actually either received or ready.

      Connected - we only emit the dataReceived() signal when pushData() is called, but when an input funnel pushes data to its output funnel, it bypasses the pushData() and goes straight to processCombinedData() to avoid overwriting the inputBuffer every time. This also seems incorrect.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            Unassigned Unassigned
            tinjapaavoseppa Tinja Paavoseppä
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes