-
Bug
-
Resolution: Fixed
-
P2: Important
-
6.8
-
None
-
13
-
9de508581 (dev), 3a2caf9ec (6.10), f48fb557c (6.9), 01ad63f49 (6.9.2), 8a1127f80 (tqtc/lts-6.8)
-
Foundation Sprint 134, Foundation Sprint 135
The QHttp2Stream implementation doesn't provide any handling or
verification of the HTTP/2 spec. The gRPC over HTTP/2 protocol clearly
defines how Response-Headers, Trailers and Trailers-Only have to behave.
Currently we are missing crucial steps of validation:
- HTTP status to be 200
- Trailers contain gRPC status
- Valid gRPC content-type found
Ref: https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md#responses
| For Gerrit Dashboard: QTBUG-138494 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 660982,15 | QGrpcHttp2Channel: validate received headers using protocol rules | dev | qt/qtgrpc | Status: MERGED | +2 | +1 |
| 666207,2 | QGrpcHttp2Channel: validate received headers using protocol rules | 6.10 | qt/qtgrpc | Status: MERGED | +2 | 0 |
| 666292,3 | QGrpcHttp2Channel: validate received headers using protocol rules | 6.9 | qt/qtgrpc | Status: MERGED | +2 | 0 |
| 666775,2 | QGrpcHttp2Channel: validate received headers using protocol rules | 6.9.2 | qt/qtgrpc | Status: MERGED | +2 | 0 |
| 666824,4 | QGrpcHttp2Channel: validate received headers using protocol rules | tqtc/lts-6.8 | qt/tqtc-qtgrpc | Status: MERGED | +2 | 0 |