Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-138520

Harden QTextStream's internal APIs

XMLWordPrintable

    • 2
    • 7d8e7a23c (tqtc/lts-6.5), 27f255eff (tqtc/lts-6.5), d5ef3f531 (dev), 676441275 (6.10), dfc84848f (6.9), f6a0909bb (6.9), c2a34e76b (tqtc/lts-6.5), f661e21a7 (tqtc/lts-6.8), 324374917 (tqtc/lts-6.8), 65609c536 (tqtc/lts-6.5), 29c660b2f (tqtc/lts-6.5)
    • Foundation Sprint 134

      As a security-critical component, QTextStream should have internal APIs that are hard to abuse. But there are error-prone (ptr, size) functions, which should be using views instead. And there's, in particular, the putString() overload set, which is "dangerous", since it contains (ptr, size, bool=false) and (view, bool) overloads which are prone to incorrectly resolve some (p, n) overloads towards the latter instead of the former (e.g. if the ptr isn't QChar, but something accepted by the view).

      Acceptance criteria:

      • replace (ptr, n) functions with ones taking view
      • either replace the bool parameter by a tag struct, or split putString() into putString() and putNumber().

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            mmutz Marc Mutz
            mmutz Marc Mutz
            Vladimir Minenko Vladimir Minenko
            Alex Blasche Alex Blasche
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes