Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-138629

qlocale_win's toUpper/Lower is using LCMapString when the docs recommend LCMapStringEx

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • P3: Somewhat important
    • None
    • 6.10.0 Beta2
    • Core: Locales (i18n)
    • None
    • Windows

    Description

      https://learn.microsoft.com/en-us/windows/win32/api/winnls/nf-winnls-lcmapstringw has this note:

      Note For interoperability reasons, the application should prefer the LCMapStringEx function to LCMapString because Microsoft is migrating toward the use of locale names instead of locale identifiers for new locales. This recommendation applies especially to custom locales, including those created by Microsoft. Any application that will be run only on Windows Vista and later should use LCMapStringEx.

      I don't think we still support Windows Vista?

      git-blame fingers https://codereview.qt-project.org/c/qt/qtbase/+/476728 CC ulherman

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-138705 Windows backend of QLocale::toLower() does not implement Greek Final Sigma rule

          • Not Evaluated - Not yet evaluated/prioritized
          • Reported

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-138630 QLocale::toUpper() is not 64-bit-safe on Windows

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Reported
          split from

          Task - A task that needs to be done. QTBUG-121193 Port QLocale on MS away from the use of LCID; use names instead

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Open
          For Gerrit Dashboard: QTBUG-138629
          # Subject Branch Project Status CR V
          663735,6 WIP: port QLocale/Win from LCMapString() to LCMapStringEx() dev qt/qtbase Status: NEW -2 +1

          Activity

            People

              Eddy Edward Welbourne
              mmutz Marc Mutz
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There is 1 open Gerrit change