-
Bug
-
Resolution: Fixed
-
P2: Important
-
None
-
6.10
-
5
-
b5a1bf401 (6.10), 90c72779b (6.10), 7969c0c8b (6.10), 7d884ceb8 (6.10), 6ce91b03d (dev), ff7947d93 (dev), cf6d55a4f (6.10), 92c5b1b00 (6.10), da7123a96 (dev), 691b6cf3f (dev), 742552aa4 (6.10), e3260071e (6.10), edafe62cb (dev), 3d1a1db45 (6.10)
QmlTreeModel inherited the concept and much of the API from QmlTableModel. Many functions have been copied to the new class with minimal modifications. While this is ok for an initial commit and evaluation, it will be bad for maintainance.
Therefore, the two classes should be merged into an abstract class where possible.
For Gerrit Dashboard: QTBUG-138703 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
663488,7 | Add moc include to QQmlTreeModel | dev | qt/qtdeclarative | Status: MERGED | +2 | 0 |
663518,16 | Backport some changes from QmlTreeModel to QmlTableModel | dev | qt/qtdeclarative | Status: MERGED | +2 | 0 |
663559,13 | Reorder the functions in QmlTreeModel | dev | qt/qtdeclarative | Status: MERGED | +2 | 0 |
663588,6 | Remove columnCountChanged in setRowsPrivate | dev | qt/qtdeclarative | Status: MERGED | +2 | 0 |
663590,15 | Derive QmlTableModel from QAbstractItemModel | dev | qt/qtdeclarative | Status: MERGED | +2 | 0 |
663593,20 | Qml[Table|Tree]Model: Put column handling in abstract class | dev | qt/qtdeclarative | Status: MERGED | +2 | 0 |
663694,7 | Qml[Table|Tree]Model: Move setData to QAbstractColumnModel | dev | qt/qtdeclarative | Status: MERGED | +2 | 0 |
663721,4 | Qml[Table|Tree]Model: Move data to QAbstractColumnModel | dev | qt/qtdeclarative | Status: MERGED | +2 | 0 |
663740,7 | Qml[Table|Tree]Model: Move validateRow to QAbstractColumnModel | dev | qt/qtdeclarative | Status: MERGED | +2 | +1 |
664170,2 | Add moc include to QQmlTreeModel | 6.10 | qt/qtdeclarative | Status: MERGED | +2 | 0 |
664171,2 | Backport some changes from QmlTreeModel to QmlTableModel | 6.10 | qt/qtdeclarative | Status: MERGED | +2 | 0 |
664172,2 | Reorder the functions in QmlTreeModel | 6.10 | qt/qtdeclarative | Status: MERGED | +2 | 0 |
664173,2 | Remove columnCountChanged in setRowsPrivate | 6.10 | qt/qtdeclarative | Status: MERGED | +2 | 0 |
666523,1 | Derive QmlTableModel from QAbstractItemModel | 6.10 | qt/qtdeclarative | Status: MERGED | +2 | 0 |
667175,5 | Qml[Table|Tree]Model: Put column handling in abstract class | 6.10 | qt/qtdeclarative | Status: MERGED | +2 | +1 |
668163,2 | Qml[Table|Tree]Model: Move setData to QAbstractColumnModel | 6.10 | qt/qtdeclarative | Status: MERGED | +2 | 0 |
668164,2 | Qml[Table|Tree]Model: Move data to QAbstractColumnModel | 6.10 | qt/qtdeclarative | Status: MERGED | +2 | 0 |
670830,2 | Qml[Table|Tree]Model: Move validateRow to QAbstractColumnModel | 6.10 | qt/qtdeclarative | Status: MERGED | +2 | 0 |