Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-139458

Redesign sink parameter in Out and LineWriters

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Unresolved
    • Icon: P3: Somewhat important P3: Somewhat important
    • Some future release
    • None
    • QML: Tooling
    • None

      When creating an `OutWriter` a "writtenStr" sink will automatically be added, see `OutWriter(LineWriter &lw)`

      However LineWriter requires Sink constructor argument. This propagates also to IndentingLineWriter. In practice it means that this sink might actually be optional.

      The proposal is to remove `Sink` functor and associated members or at least minimize risks for the misuse and confusion.
      Without deep analysis, it seems that LineWriter can simply have a QString inside or having a reference to it   

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            qtqmlteam Qt Qml Team User
            dima.a Dmitrii Akshintsev
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                There are no open Gerrit changes