Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-139623

OutWriter get rid of SkipComments

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Unresolved
    • Icon: P2: Important P2: Important
    • Some future release
    • None
    • QML: Tooling
    • None

      Atm only `MethodInfo::signature` is using this option, however because MethodParameter-s might be difficult to "print"-out and could be complex, maybe there could be other ways, but using OutWriter seemed the simplest option following do not repeat yourself principle.

      The root-cause why we need this SkipComments, because Comments are being fetched and attached to Items way before OutWriter is constructed. However while we writeOut items (for example DomItem "containing" MethodParameter ) the comments are being fetched in the DomItem::writeOutPre -> ow.itemStart
      However if itemStart was not called, ow.writeRegion will check stack (unless we use this flag) 

      (initially it was introduced as part of the Document symbols feature for Qmlls, again, maybe there are alternative ways preparing these signatures...)

      related to QTBUG-123386
      QTBUG-128423 could be related as well

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            qtqmlteam Qt Qml Team User
            dima.a Dmitrii Akshintsev
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                There are no open Gerrit changes