Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-139705

Clean redundant requestActivate() QtBase/QtDeclarative

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: P4: Low P4: Low
    • None
    • None
    • Other
    • None
    • All
    • 10b5ce432 (dev), 49dbf10d6 (6.10), 3064c33b0 (6.9), cdb016647 (tqtc/lts-6.8), d1f70d8a9 (tqtc/lts-6.5), 5d433b781 (dev), 8036ab33f (dev), 206bd055e (6.10), 5b568650b (6.10), 96322d663 (tqtc/lts-6.8), 752dadcad (tqtc/lts-6.8)

      Many tests call requestActivate() immediately after show().
      However, this is often redundant because show() should already activate the window.

      If the window is not activated after show() , instead of calling requestActivate() , add:

        QVERIFY(QTest::qWaitForWindowActive(someWindow)) after show().

       

        For Gerrit Dashboard: QTBUG-139705
        # Subject Branch Project Status CR V
        671552,4 Remove redundant calls in tst_QWindow::activateDeactivateEvent dev qt/qtbase Status: NEW 0 +1
        671951,3 Remove irrelevant QSKIP related to requestActivate in tst_QComboBox dev qt/qtbase Status: NEW 0 0
        671952,2 Remove irrelevant QSKIP related to requestActivate tst_QWidget_window dev qt/qtbase Status: NEW 0 -1
        671954,3 Remove irrelevant QSKIP related to requestActivate in tst_QFocusEvent dev qt/qtbase Status: NEW 0 0
        672710,3 Remove redundant calls in tst_QQuickFrameBufferObject dev qt/qtdeclarative Status: NEW 0 0
        672980,3 Remove Redundant calls to requestActivate in tst_QQuickGridView dev qt/qtdeclarative Status: NEW 0 0
        672981,3 Remove redundant calls to requestActivate in tst_QQuickListView dev qt/qtdeclarative Status: NEW 0 0
        672982,3 Remove redundant call to requestActivate in tst_QQuickMouseArea dev qt/qtdeclarative Status: NEW 0 0
        672983,3 Remove redundant calls to requestActivate in tst_QQuickShortcut dev qt/qtdeclarative Status: NEW 0 0
        672984,3 Remove redundant calls to requestActivate in tst_QQuickText dev qt/qtdeclarative Status: NEW 0 0
        672985,3 Remove redundant calls to requestActivate in tst_QQuickTextInput dev qt/qtdeclarative Status: NEW 0 0
        672986,3 Remove redundant calls to requestActivate in tst_QQuickWindow dev qt/qtdeclarative Status: NEW 0 0
        672987,3 Remove redundant call in tst_customization::comboPopup dev qt/qtdeclarative Status: NEW 0 0
        672988,3 Remove redundant calls to requestActivate() in tst_focus dev qt/qtdeclarative Status: NEW 0 0
        672989,3 Remove redundant calls to requestActivate in tst_QQuickIconImage dev qt/qtdeclarative Status: NEW 0 0
        672990,3 Remove redundant calls to requestActivate in tst_QQuickMenu dev qt/qtdeclarative Status: NEW 0 0
        672991,3 Remove redundant calls to requestActivate in tst_QQuickNinePatchImage dev qt/qtdeclarative Status: NEW 0 0
        672992,3 Remove redundant calls to requestActivate in tst_QQuickTextArea dev qt/qtdeclarative Status: NEW 0 0
        672993,3 Remove redundant calls to requestActivate in tst_QQuickTextField dev qt/qtdeclarative Status: NEW 0 0
        672994,2 Remove redundant call to requestActivate in tst_activeFocus dev qt/qtdeclarative Status: NEW 0 0
        672995,2 Remove redundant call to requestActivate in tst_QQuickWidget dev qt/qtdeclarative Status: NEW 0 +1
        687251,1 Remove redundant calls in tst_QWindow::enterLeaveOnWindowShowHide tqtc/lts-6.5 qt/tqtc-qtbase Status: NEW 0 0
        687252,1 Remove redundant calls in tst_QFocusEvent to requestActivate tqtc/lts-6.5 qt/tqtc-qtbase Status: NEW +2 0
        671543,6 Redundant calls tst_QWindow::modalWindowEnterEventOnHide_QTBUG35109 dev qt/qtbase Status: MERGED +2 +1
        671579,6 Remove redundant calls in tst_QWindow::enterLeaveOnWindowShowHide dev qt/qtbase Status: MERGED +2 0
        671953,4 Remove redundant calls in tst_QFocusEvent to requestActivate dev qt/qtbase Status: MERGED +2 0
        672709,2 Remove redundant calls to requestActivate in tst_QQuickFocusScope dev qt/qtdeclarative Status: ABANDONED 0 0
        673046,2 Redundant calls tst_QWindow::modalWindowEnterEventOnHide_QTBUG35109 6.10 qt/qtbase Status: MERGED +2 0
        673195,2 Redundant calls tst_QWindow::modalWindowEnterEventOnHide_QTBUG35109 6.9 qt/qtbase Status: MERGED +2 0
        673223,2 Redundant calls tst_QWindow::modalWindowEnterEventOnHide_QTBUG35109 tqtc/lts-6.8 qt/tqtc-qtbase Status: MERGED +2 0
        673296,2 Redundant calls tst_QWindow::modalWindowEnterEventOnHide_QTBUG35109 tqtc/lts-6.5 qt/tqtc-qtbase Status: MERGED +2 0
        686607,2 Remove redundant calls in tst_QWindow::enterLeaveOnWindowShowHide 6.10 qt/qtbase Status: MERGED +2 0
        686608,2 Remove redundant calls in tst_QFocusEvent to requestActivate 6.10 qt/qtbase Status: MERGED +2 0
        686765,2 Remove redundant calls in tst_QFocusEvent to requestActivate tqtc/lts-6.8 qt/tqtc-qtbase Status: MERGED +2 0
        686766,2 Remove redundant calls in tst_QWindow::enterLeaveOnWindowShowHide tqtc/lts-6.8 qt/tqtc-qtbase Status: MERGED +2 0

            fredericl Frederic Lefebvre
            fredericl Frederic Lefebvre
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                There are 23 open Gerrit changes