Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-140119

Be more specific about the appearance of icons in QMenu for macOS

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: P2: Important P2: Important
    • None
    • 6.7.3, 6.8, 6.9, 6.10, 6.11, 6.12
    • Documentation
    • None
    • All

      The recent change done with https://codereview.qt-project.org/q/change:Ie4fb3e6618486233d64a7818be19a42ed9a2a852 caused a "virtual regression" that affects macOS, which now doesn't show icons in menus by default on macOS anymore.

      While the new behavior may be more appropriate and consistent for the platform, there is no mention about this other than the 6.7.3 release notes (not even a minor version release, so this may become unexpected for those directly switching from <=6.7.2 to >=6.8), which may be puzzling especially to people not fully experienced with that OS or Apple's oddities guidelines, or those that have been developing cross-platform apps for a long time.

      Icons for menu items are considered normal for the majority of common platforms, making macOS behavior an odd (or at least unexpected) exception that should be explicitly noted in the documentation for that platform, along with any other one that follows that behavior by default.

      In my opinion:

      • QAction docs should specify such "exceptions" at least in the icon and iconVisibleInMenu properties, but probably in the primary ctor and in the detailed section of the docs as well;
      • QMenu should clarify this at least in its detailed section and its icon property; a brief note about the optional visibility of the icon of new actions could be added to the related addAction() functions;

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            docteam Qt Documentation Team
            musicamante Maurizio Berti
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                There are no open Gerrit changes