Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-140150

[cmake] qconfig.h and friends generated without inclusion guards

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: P2: Important P2: Important
    • None
    • 6.10
    • Build System: CMake
    • None
    • 901ccf760 (dev), a13a28772 (6.10)

      the feature config files are generated without inclusion guards.

      this causes issues with the SIMD detection code for universal binaries on macos:

      • qconfig.h defines e.g. QT_COMPILER_SUPPORTS_SSE2
      • qcompilerdetection.h potentially undefines it again
      • later inclusions of qconfig.h re-defines it again.

      on macos one should typically rely on the compiler-provided preprocessor defines like _SSE_, as they are populated based on the minimum deployment target.

        For Gerrit Dashboard: QTBUG-140150
        # Subject Branch Project Status CR V

            qtbuildsystem Qt Build System Team
            timblechmann tim blechmann
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                There is 1 open Gerrit change